Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update ansys-sphinx-theme to fix documentation build #4068

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

This update consists in using a previous dependency of ansys-sphinx-theme (aka pydata-sphinx-theme) whose latest version (0.15.1) broke the side bar of the documentation page.

Note: this update consists in using a previous dependency
(pydata-sphinx-theme) whose latest version (0.15.1) broke
the side bar of the documentation page.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Jan 12, 2024
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,8 +40,13 @@ jobs:
with:
python-version: 3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python-version: 3.8
python-version: 3.10

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Revathyvenugopal162 thanks for pointing that out :)

Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MaxJPRey MaxJPRey changed the title Update ansys sphinx theme to fix documentation build DOC: Update ansys-sphinx-theme to fix documentation build Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ab3443b) 81.77% compared to head (5dcac7e) 81.78%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4068   +/-   ##
=======================================
  Coverage   81.77%   81.78%           
=======================================
  Files         184      184           
  Lines       63792    63792           
=======================================
+ Hits        52168    52171    +3     
+ Misses      11624    11621    -3     

@SMoraisAnsys SMoraisAnsys merged commit f73d03c into main Jan 12, 2024
15 checks passed
@SMoraisAnsys SMoraisAnsys deleted the maint/fix_doc_side_bar branch January 12, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants