Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove edb json configuration support #4086

Merged
merged 5 commits into from
Jan 24, 2024
Merged

remove edb json configuration support #4086

merged 5 commits into from
Jan 24, 2024

Conversation

ring630
Copy link
Collaborator

@ring630 ring630 commented Jan 16, 2024

The feature is moved to PyAnsys-Edb.

#4079 (comment)
#4059 (comment)

@SMoraisAnsys please ignore above too PR. The code is already moved to PyAnsys-Edb.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a4e401) 81.88% compared to head (3ad8085) 81.90%.

❗ Current head 3ad8085 differs from pull request most recent head 06be454. Consider uploading reports for the commit 06be454 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4086      +/-   ##
==========================================
+ Coverage   81.88%   81.90%   +0.02%     
==========================================
  Files         184      182       -2     
  Lines       64015    63747     -268     
==========================================
- Hits        52417    52215     -202     
+ Misses      11598    11532      -66     

@github-actions github-actions bot added the edb label Jan 17, 2024
Copy link
Collaborator

@svandenb-dev svandenb-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ring630 ring630 enabled auto-merge (squash) January 24, 2024 07:46
@ring630 ring630 merged commit ad3ae79 into main Jan 24, 2024
13 of 14 checks passed
@ring630 ring630 deleted the remove_edb_cfg_json branch January 24, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants