Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icepak csv example improvement #4100

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

lorenzovecchietti
Copy link
Collaborator

@lorenzovecchietti lorenzovecchietti commented Jan 18, 2024

I improve the example with these modifications:

  • remove 2R network assignment function from the example to use the one already present in pyAEDT
  • remove the board side column from the csv file and remove the line for the board creation (Icepak csv example - csv file update example-data#220)
  • remove and substitution of deprecated methods
  • coding styles improvements

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a53f78d) 81.87% compared to head (bb6ff38) 79.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4100      +/-   ##
==========================================
- Coverage   81.87%   79.37%   -2.50%     
==========================================
  Files         184      184              
  Lines       63961    63961              
==========================================
- Hits        52369    50770    -1599     
- Misses      11592    13191    +1599     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorenzovecchietti lorenzovecchietti marked this pull request as ready for review January 19, 2024 08:19
@lorenzovecchietti lorenzovecchietti enabled auto-merge (squash) January 19, 2024 08:19
@lorenzovecchietti lorenzovecchietti merged commit 7f7bace into main Jan 19, 2024
15 checks passed
@lorenzovecchietti lorenzovecchietti deleted the Enhancement/icepak_csv_example branch January 19, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants