issue-4102-reverting-implementation-in-get_scalar_field_value #4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4103 +/- ##
=======================================
Coverage 81.85% 81.86%
=======================================
Files 184 184
Lines 63987 63994 +7
=======================================
+ Hits 52377 52387 +10
+ Misses 11610 11607 -3 |
lorenzovecchietti
approved these changes
Jan 19, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplified implementation GetTopEntryValue works fine in small models but it is failing in the big model (mesh ~27M). Therefore I am reverting this implementation to the previous one with temp file exporting and reading it to extract value which we verified that works fine with bigger models. GetTopEntryValue was working fine with versions <=22R2 but something happened in later versions on the native scripting side.