Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon operations added #4127

Merged
merged 15 commits into from
Jan 25, 2024
Merged

Polygon operations added #4127

merged 15 commits into from
Jan 25, 2024

Conversation

svandenb-dev
Copy link
Collaborator

Added:
polygon.move method
polygon.rotate method
polygon.scale method
polygon.move_layer method

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the edb label Jan 24, 2024
@svandenb-dev svandenb-dev added the enhancement New features or code improvements label Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f778b5a) 81.92% compared to head (f47d678) 81.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4127      +/-   ##
==========================================
+ Coverage   81.92%   81.93%   +0.01%     
==========================================
  Files         182      182              
  Lines       63800    63846      +46     
==========================================
+ Hits        52268    52313      +45     
- Misses      11532    11533       +1     

ring630
ring630 previously approved these changes Jan 24, 2024
Copy link
Collaborator

@ring630 ring630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job here, just a missing docstring description.
Btw, can't the scaling factor of scale be an integer ?

pyaedt/edb_core/edb_data/primitives_data.py Outdated Show resolved Hide resolved
pyaedt/edb_core/edb_data/primitives_data.py Outdated Show resolved Hide resolved
pyaedt/edb_core/edb_data/primitives_data.py Outdated Show resolved Hide resolved
pyaedt/edb_core/edb_data/primitives_data.py Outdated Show resolved Hide resolved
pyaedt/edb_core/edb_data/primitives_data.py Outdated Show resolved Hide resolved
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
svandenb-dev and others added 5 commits January 25, 2024 11:45
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
@SMoraisAnsys
Copy link
Collaborator

pre-commit.ci autofix

@svandenb-dev svandenb-dev enabled auto-merge (squash) January 25, 2024 16:05
@svandenb-dev svandenb-dev merged commit b597a6e into main Jan 25, 2024
15 checks passed
@svandenb-dev svandenb-dev deleted the move_polygon_added branch January 25, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
3 participants