Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISC: follow pyansys repo guidelines #4141

Merged
merged 4 commits into from
Jan 31, 2024
Merged

MISC: follow pyansys repo guidelines #4141

merged 4 commits into from
Jan 31, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

As title says.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d93789f) 81.93% compared to head (69024b0) 79.44%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4141      +/-   ##
==========================================
- Coverage   81.93%   79.44%   -2.50%     
==========================================
  Files         182      182              
  Lines       63850    63850              
==========================================
- Hits        52316    50723    -1593     
- Misses      11534    13127    +1593     

MaxJPRey
MaxJPRey previously approved these changes Jan 27, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

AUTHORS Outdated Show resolved Hide resolved
Samuelopez-ansys and others added 2 commits January 31, 2024 08:08
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys SMoraisAnsys merged commit 8d0c6c5 into main Jan 31, 2024
14 checks passed
@SMoraisAnsys SMoraisAnsys deleted the misc/add_authors branch January 31, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants