Create new function to import GDS file in HFSS #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
==========================================
+ Coverage 79.46% 81.94% +2.47%
==========================================
Files 182 182
Lines 63852 63854 +2
==========================================
+ Hits 50739 52322 +1583
+ Misses 13113 11532 -1581 |
…3774_GDSii_Import_in_HFSS
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…3774_GDSii_Import_in_HFSS
for more information, see https://pre-commit.ci
gmalinve
reviewed
Jan 29, 2024
gmalinve
reviewed
Jan 29, 2024
gmalinve
reviewed
Jan 30, 2024
|
@amichel0205 there are still many lines not covered by test, I'd improve that. |
Fixed typo and improve clarity of commenst
PipKat
reviewed
Jan 31, 2024
PipKat
reviewed
Jan 31, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
…3774_GDSii_Import_in_HFSS
Update test_20_HFSS.py/test_68_import_gds_3d Add example section in documentation section
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…3774_GDSii_Import_in_HFSS
work in non graphical mode
for more information, see https://pre-commit.ci
Samuelopez-ansys
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new function to import GDS file in HFSS.
It seems this function works only in Graphical Mode.
Close #3992