Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pyclient support #4145

Merged
merged 6 commits into from
Feb 2, 2024
Merged

added pyclient support #4145

merged 6 commits into from
Feb 2, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0527abf) 31.20% compared to head (894fb39) 82.00%.
Report is 1 commits behind head on main.

❗ Current head 894fb39 differs from pull request most recent head bae9674. Consider uploading reports for the commit bae9674 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4145       +/-   ##
===========================================
+ Coverage   31.20%   82.00%   +50.79%     
===========================================
  Files         182      182               
  Lines       63856    63861        +5     
===========================================
+ Hits        19929    52368    +32439     
+ Misses      43927    11493    -32434     

pyaedt/desktop.py Outdated Show resolved Hide resolved
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 1f69fe2 into main Feb 2, 2024
13 checks passed
@maxcapodi78 maxcapodi78 deleted the python_client branch February 2, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants