MISC: add logger error when object not found #4147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following user feedback (#4001) we add an extra error log to clarify the fact that some calls might not work as expected since some objects don't exist (or at least are not found)
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4147 +/- ##
===========================================
+ Coverage 31.12% 81.93% +50.80%
===========================================
Files 182 182
Lines 63851 63852 +1
===========================================
+ Hits 19875 52315 +32440
+ Misses 43976 11537 -32439 |
|
@SMoraisAnsys Maybe we should add a test |
I added a test over the log message content. Is that what you wanted or had you something else in mind ? |
MaxJPRey
reviewed
Jan 29, 2024
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following user feedback (#4001) this PR adds an extra error log to clarify the fact that some calls might not work as expected since some objects don't exist (or at least are not found).
Closes #4001