Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue_4170_bug_resolution #4174

Merged
merged 2 commits into from
Feb 1, 2024
Merged

issue_4170_bug_resolution #4174

merged 2 commits into from
Feb 1, 2024

Conversation

nnetake
Copy link
Collaborator

@nnetake nnetake commented Feb 1, 2024

Resetting _color_id to 0 when _color_id is greater than or equal to number of CSS4_COLORS.

Close #4170

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@nnetake nnetake requested a review from gmalinve February 1, 2024 10:50
@nnetake nnetake changed the title will not raise a list index out of range error at 1294 issue_4170_bug_resolution Feb 1, 2024
@nnetake nnetake added the bug Something isn't working label Feb 1, 2024
@nnetake nnetake linked an issue Feb 1, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e56aba9) 81.94% compared to head (32b76a0) 81.94%.

❗ Current head 32b76a0 differs from pull request most recent head f63f2fe. Consider uploading reports for the commit f63f2fe to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4174   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files         182      182           
  Lines       63852    63852           
=======================================
+ Hits        52323    52324    +1     
+ Misses      11529    11528    -1     

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 1, 2024 12:56
@Samuelopez-ansys Samuelopez-ansys merged commit b25e933 into main Feb 1, 2024
14 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the issue_4170_bug_resolution branch February 1, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index error in modules/Material.py -> Material.__init__() (color assignment)
3 participants