Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented new VirtualCompliance class to generate automatically reports #4176

Merged
merged 35 commits into from
Feb 2, 2024

Conversation

maxcapodi78
Copy link
Collaborator

pass/fail table based on json configurations

…ort and pass/fail table based on json configurations
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 113 lines in your changes are missing coverage. Please review.

Comparison is base (1f69fe2) 82.05% compared to head (8fc1f65) 82.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4176      +/-   ##
==========================================
+ Coverage   82.05%   82.09%   +0.03%     
==========================================
  Files         182      183       +1     
  Lines       63892    64462     +570     
==========================================
+ Hits        52428    52921     +493     
- Misses      11464    11541      +77     

pyaedt/generic/pdf.py Outdated Show resolved Hide resolved
maxcapodi78 and others added 6 commits February 1, 2024 22:26
minor improvements
minor improvements
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Alberto-DM
Alberto-DM previously approved these changes Feb 2, 2024
Copy link
Collaborator

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 added the enhancement New features or code improvements label Feb 2, 2024
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pragma no cover multiple cases

pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/generic/compliance.py Show resolved Hide resolved
pyaedt/modules/PostProcessor.py Show resolved Hide resolved
pyaedt/modules/PostProcessor.py Show resolved Hide resolved
@Samuelopez-ansys Samuelopez-ansys dismissed stale reviews from Alberto-DM and themself via 5440745 February 2, 2024 16:19
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit aa0e32f into main Feb 2, 2024
13 of 14 checks passed
@maxcapodi78 maxcapodi78 deleted the compliance branch February 2, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants