Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toml support #4189

Merged
merged 24 commits into from
Feb 9, 2024
Merged

Add toml support #4189

merged 24 commits into from
Feb 9, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

maxcapodi78 added 2 commits February 6, 2024 09:04
Add Toml support to files
82dfa8f 
improved report generation
Add Toml support to files
eae47c4 
improved report generation
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Feb 6, 2024
Samuelopez-ansys
Samuelopez-ansys previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited

Codecov Report

Attention: 131 lines in your changes are missing coverage. Please review.

Comparison is base (420c882) 82.08% compared to head (966919b) 32.76%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #4189       +/-   ##
===========================================
- Coverage   82.08%   32.76%   -49.32%     
===========================================
  Files         183      183               
  Lines       64466    64555       +89     
===========================================
- Hits        52914    21154    -31760     
- Misses      11552    43401    +31849

PipKat
PipKat reviewed Feb 6, 2024
View reviewed changes
pyaedt/generic/compliance.py Outdated Show resolved Hide resolved
PipKat
PipKat reviewed Feb 6, 2024
View reviewed changes
pyaedt/generic/compliance.py Outdated Show resolved Hide resolved
Samuelopez-ansys and others added 4 commits February 7, 2024 14:20
@Samuelopez-ansys
Merge branch 'main' into add_toml_support
966919b
@maxcapodi78 @PipKat
Apply suggestions from code review
a5866ce 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Apply suggestions from code review
da19cb7 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Apply suggestions from code review
1a22dfb 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024 •
edited

Codecov Report

Attention: 87 lines in your changes are missing coverage. Please review.

Comparison is base (420c882) 82.08% compared to head (b3730e9) 81.99%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4189      +/-   ##
==========================================
- Coverage   82.08%   81.99%   -0.09%     
==========================================
  Files         183      183              
  Lines       64466    64555      +89     
==========================================
+ Hits        52914    52934      +20     
- Misses      11552    11621      +69

maxcapodi78 and others added 14 commits February 8, 2024 16:50
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
2bae63e 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
e1c7415 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
4b6b38f 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
38f62d9 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
dfa77c4 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
4a2489a 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
2afe665 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
9dbc5d3 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/general_methods.py
c57871e 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/configurations.py
5372d3e 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/configurations.py
66b547d 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/configurations.py
aa47aec 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@maxcapodi78 @PipKat
Update pyaedt/generic/configurations.py
02a9558 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
improved docstring
b3730e9
@maxcapodi78 maxcapodi78 enabled auto-merge (squash) February 9, 2024 10:03
Samuelopez-ansys
Samuelopez-ansys approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Good job creating a configuration file standard reader

@maxcapodi78 maxcapodi78 merged commit 6802d9f into main Feb 9, 2024
14 checks passed
@maxcapodi78 maxcapodi78 deleted the add_toml_support branch February 9, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

Assignees
No one assigned
Labels
maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@maxcapodi78 @codecov-commenter @PipKat @Samuelopez-ansys