Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ERL computation in Circuit through SPISIM launched in non-graphical mode #4219

Merged
merged 12 commits into from
Feb 14, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3460217) 82.00% compared to head (8f23390) 82.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4219   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files         183      183           
  Lines       64639    64715   +76     
=======================================
+ Hits        53005    53071   +66     
- Misses      11634    11644   +10     

SMoraisAnsys
SMoraisAnsys previously approved these changes Feb 12, 2024
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
pyaedt/circuit.py Outdated Show resolved Hide resolved
ring630
ring630 previously approved these changes Feb 12, 2024
Copy link
Collaborator

@ring630 ring630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

maxcapodi78 and others added 3 commits February 12, 2024 17:17
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
Co-authored-by: SMoraisAnsys <146729917+SMoraisAnsys@users.noreply.github.com>
@SMoraisAnsys
Copy link
Collaborator

@maxcapodi78 I thought that one of my changes was the reason of the error but I'm not able to reproduce it locally when executing the added test alone. I'm relaunching the solver tests

@ring630 ring630 merged commit eac02f8 into main Feb 14, 2024
15 checks passed
@ring630 ring630 deleted the add_erl branch February 14, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants