Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix q3d dynamic link #4220

Merged
merged 10 commits into from
Feb 16, 2024
Merged

fix q3d dynamic link #4220

merged 10 commits into from
Feb 16, 2024

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@gmalinve gmalinve self-assigned this Feb 12, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Feb 12, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82f373a) 82.01% compared to head (705ec55) 82.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4220      +/-   ##
==========================================
- Coverage   82.01%   82.00%   -0.01%     
==========================================
  Files         183      183              
  Lines       64727    64728       +1     
==========================================
- Hits        53083    53079       -4     
- Misses      11644    11649       +5     

cmesibov
cmesibov previously approved these changes Feb 14, 2024
Copy link
Collaborator

@cmesibov cmesibov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass! Good to go!

@gmalinve gmalinve merged commit 9b2610d into main Feb 16, 2024
15 checks passed
@gmalinve gmalinve deleted the q3d_dynamic_link_type branch February 16, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Twinbuilder Q3D Dynamic link produces incorrect model
3 participants