Fix & Improvement to parametric heatsink function #4226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4226 +/- ##
=======================================
Coverage 81.99% 81.99%
=======================================
Files 183 183
Lines 64728 64725 -3
=======================================
- Hits 53075 53073 -2
+ Misses 11653 11652 -1 |
Hi @lorenzovecchietti is it possible to derive deprecated method from the new one in order to reduce amount of code to tests and mantain? |
PipKat
reviewed
Feb 14, 2024
PipKat
reviewed
Feb 14, 2024
PipKat
reviewed
Feb 14, 2024
PipKat
reviewed
Feb 14, 2024
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Samuelopez-ansys
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New function allows multiple parametric heatsink with any position and orientation, automatically placing it on top of a face. It is also possible to express dimensions relative to the base dimensions.
The new function also fixes a few bugs from the old one.