Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix freq sweep and deprecate q3d method #4235

Merged
merged 13 commits into from
Feb 19, 2024
Merged

fix freq sweep and deprecate q3d method #4235

merged 13 commits into from
Feb 19, 2024

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b2610d) 82.01% compared to head (b33f9d5) 82.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4235      +/-   ##
==========================================
- Coverage   82.01%   82.00%   -0.02%     
==========================================
  Files         183      183              
  Lines       64728    64728              
==========================================
- Hits        53085    53078       -7     
- Misses      11643    11650       +7     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed this

pyaedt/modules/SolveSetup.py Outdated Show resolved Hide resolved
pyaedt/modules/SolveSetup.py Outdated Show resolved Hide resolved
@gmalinve gmalinve linked an issue Feb 16, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve merged commit f47fce7 into main Feb 19, 2024
15 checks passed
@gmalinve gmalinve deleted the fix_create_freq_sweep branch February 19, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when using function create_frequency_sweep in solver Q3D
2 participants