Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom LSF #4290

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Add custom LSF #4290

merged 2 commits into from
Feb 27, 2024

Conversation

Samuelopez-ansys
Copy link
Member

Close #4286 #4288 #4287

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Feb 27, 2024
maxcapodi78
maxcapodi78 previously approved these changes Feb 27, 2024
Copy link
Collaborator

@maxcapodi78 maxcapodi78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 Issues in 1 PR. GREAT!

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.32%. Comparing base (8f18524) to head (077441e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4290      +/-   ##
==========================================
- Coverage   81.33%   81.32%   -0.02%     
==========================================
  Files         108      108              
  Lines       51656    51663       +7     
==========================================
- Hits        42015    42014       -1     
- Misses       9641     9649       +8     

@Samuelopez-ansys Samuelopez-ansys merged commit 6e6b63d into main Feb 27, 2024
13 of 15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/issue4286 branch February 27, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSF submission, Bug located in desktop.py (pyaedt-0.7.12)
2 participants