Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix view and plot label in plot_field_from_fieldplot #4293

Merged
merged 8 commits into from Mar 1, 2024
Merged

fix view and plot label in plot_field_from_fieldplot #4293

merged 8 commits into from Mar 1, 2024

Conversation

gmalinve
Copy link
Collaborator

No description provided.

@gmalinve gmalinve self-assigned this Feb 28, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Feb 28, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2024 •
edited

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.78%. Comparing base (22380a4) to head (2a06af3).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4293      +/-   ##
==========================================
+ Coverage   81.73%   81.78%   +0.04%     
==========================================
  Files         107      107              
  Lines       51787    51806      +19     
==========================================
+ Hits        42328    42367      +39     
+ Misses       9459     9439      -20

Samuelopez-ansys
Samuelopez-ansys reviewed Feb 28, 2024
View reviewed changes
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you change the name label to scalar_name? Is not possible to keep label?

gmalinve and others added 2 commits February 29, 2024 08:48
@gmalinve @PipKat
Apply suggestions from code review
2a06af3 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@gmalinve
Merge branch 'main' into fix_plot_field_view_label
e35c25a
@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024 •
edited

Codecov Report

Attention: Patch coverage is 61.53846% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.84%. Comparing base (d8da512) to head (7568ed8).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4293      +/-   ##
==========================================
+ Coverage   81.81%   81.84%   +0.03%     
==========================================
  Files         107      107              
  Lines       52059    52078      +19     
==========================================
+ Hits        42590    42623      +33     
+ Misses       9469     9455      -14

@Samuelopez-ansys Samuelopez-ansys merged commit 490c25c into main Mar 1, 2024
14 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix_plot_field_view_label branch March 1, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@Samuelopez-ansys Samuelopez-ansys Samuelopez-ansys approved these changes

@maxcapodi78 maxcapodi78 Awaiting requested review from maxcapodi78

Assignees

@gmalinve gmalinve

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gmalinve @codecov-commenter @PipKat @Samuelopez-ansys