Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix export_field_file on grid #4308

Merged
merged 7 commits into from Mar 4, 2024

Conversation

gmalinve
Copy link
Collaborator

@gmalinve gmalinve commented Mar 1, 2024

No description provided.

@gmalinve gmalinve self-assigned this Mar 1, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Mar 1, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 76.69%. Comparing base (bfa64a5) to head (6ee5c63).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4308      +/-   ##
==========================================
- Coverage   81.85%   76.69%   -5.16%     
==========================================
  Files         107      107              
  Lines       52100    52108       +8     
==========================================
- Hits        42645    39964    -2681     
- Misses       9455    12144    +2689     

MaxJPRey
MaxJPRey previously approved these changes Mar 1, 2024
Copy link
Collaborator

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 1, 2024 10:23
@gmalinve gmalinve dismissed stale reviews from MaxJPRey and Samuelopez-ansys via e8c1b65 March 1, 2024 10:29
@Samuelopez-ansys Samuelopez-ansys merged commit b299218 into main Mar 4, 2024
14 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the export_field_file_grid_improvement branch March 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Export Field File on Grid
4 participants