Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rename built-in 'dir'. #4333

Merged
merged 1 commit into from Mar 7, 2024
Merged

Do not rename built-in 'dir'. #4333

merged 1 commit into from Mar 7, 2024

Conversation

MaxJPRey
Copy link
Collaborator

@MaxJPRey MaxJPRey commented Mar 7, 2024

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 7, 2024
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (6360c7d) to head (39a5b94).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4333   +/-   ##
=======================================
  Coverage   81.53%   81.54%           
=======================================
  Files         107      107           
  Lines       52271    52271           
=======================================
+ Hits        42621    42622    +1     
+ Misses       9650     9649    -1     

@Samuelopez-ansys Samuelopez-ansys merged commit e158395 into main Mar 7, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the maint/dir branch March 7, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants