Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix wrong version of pyedb #4356

Merged
merged 1 commit into from Mar 12, 2024

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Mar 12, 2024

For some reasons, pyedb version 0.4.2 was not published in pypi. Therefore, when one wants to work with Python 3.7, we must specify version 0.4.0 instead.

NB: Caught this error while refactoring the CI/CD. Once used, we'll avoid such error to happen !

For some reasons, pyedb version 0.4.2 was not published in pypi.
Therefore, we must use 0.4.0 instead.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 12, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.58%. Comparing base (1dcf443) to head (1b4105d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4356      +/-   ##
==========================================
- Coverage   81.59%   81.58%   -0.01%     
==========================================
  Files         107      107              
  Lines       52463    52463              
==========================================
- Hits        42805    42804       -1     
- Misses       9658     9659       +1     

@SMoraisAnsys SMoraisAnsys merged commit bf42386 into main Mar 12, 2024
15 checks passed
@SMoraisAnsys SMoraisAnsys deleted the maint/fix_pyedb_version_python_3_7 branch March 12, 2024 15:23
@MaxJPRey
Copy link
Collaborator

Nice catch @SMoraisAnsys !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants