Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load of parametrics, setups and optimizations #4366

Merged
merged 16 commits into from Mar 19, 2024

Conversation

Samuelopez-ansys
Copy link
Member

I had to add these 3 properties to the lazy load because, for Big project, it takes time to load the objects. If they are needed later, it will take the same previous time to load the objects.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 15, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@github-actions github-actions bot added the bug Something isn't working label Mar 15, 2024
SMoraisAnsys
SMoraisAnsys previously approved these changes Mar 17, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of not doing things eagerly but lazily. I would even enforce doing it by default and not using a flag to activate it.

Just a quick question, should one of the attributes _setups, _parametrics or _optimizations change after it has been set once ? If no, e.g. the Analysis is always done as post processing and nothing should change, ignore my comment. Else, the implementation should be updated as it does not allow for value modification.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.58%. Comparing base (f5f21d1) to head (6d81d7b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4366      +/-   ##
==========================================
- Coverage   81.59%   81.58%   -0.02%     
==========================================
  Files         107      107              
  Lines       52465    52489      +24     
==========================================
+ Hits        42810    42822      +12     
- Misses       9655     9667      +12     

SMoraisAnsys
SMoraisAnsys previously approved these changes Mar 19, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this refactoring !

Co-authored-by: Sébastien Morais <146729917+SMoraisAnsys@users.noreply.github.com>
@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 19, 2024 08:14
@Samuelopez-ansys Samuelopez-ansys merged commit 224d993 into main Mar 19, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the fix/lazy_load_improvement branch March 19, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants