Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export option to export_file and export_on_grid #4390

Merged
merged 3 commits into from Mar 21, 2024

Conversation

Samuelopez-ansys
Copy link
Member

Close #4383

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the enhancement New features or code improvements label Mar 21, 2024
@gmalinve
Copy link
Collaborator

gmalinve commented Mar 21, 2024

@Samuelopez-ansys you could add UTs for both.
For the export_field_file there's actually one Icepak test with the sample_points_file if you want.

@Samuelopez-ansys
Copy link
Member Author

@gmalinve I have pushed a new test, but it is not needed to increase the coverage, because if it fails, it will be an exception in the AEDP API, not in PyAEDT. But for safety, I have added one test to cover the non-default values.

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) March 21, 2024 11:08
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.64%. Comparing base (66af817) to head (fd4495c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4390   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files         109      109           
  Lines       52593    52604   +11     
=======================================
+ Hits        42938    42948   +10     
- Misses       9655     9656    +1     

@Samuelopez-ansys Samuelopez-ansys merged commit ddb5cf0 into main Mar 21, 2024
15 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_4383 branch March 21, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add export_options to export_field_file()
3 participants