Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Vale false positives for google.header #426

Merged
merged 13 commits into from
Apr 18, 2024
Merged

Conversation

dipinknair
Copy link
Contributor

  • Update vale to latest 3.3.0
  • Change accept.txt path and update

@dipinknair dipinknair linked an issue Mar 25, 2024 that may be closed by this pull request
@github-actions github-actions bot added maintenance Package and maintenance related bug Something isn't working labels Mar 25, 2024
.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
@RobPasMue
Copy link
Member

@dipinknair - have you been able to investigate further?

@dipinknair
Copy link
Contributor Author

@dipinknair - have you been able to investigate further?

I haven't been able to identify the issue. I will try again and let you know

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 11, 2024
@RobPasMue RobPasMue enabled auto-merge (squash) April 18, 2024 08:08
@RobPasMue RobPasMue merged commit a15aa89 into main Apr 18, 2024
13 checks passed
@RobPasMue RobPasMue deleted the fix/vale-google-header branch April 18, 2024 08:14
github-actions bot pushed a commit that referenced this pull request Apr 18, 2024
* udpate vale and accept list

* udpate pre-commit

* udpate .gitignore

* udpate accept

* add no exit flag

* test only doc style action

* test modifying warnings

* use ansys action

---------

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate vale issues
3 participants