Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Polygon curve #52

Closed
RobPasMue opened this issue Sep 4, 2022 · 4 comments · Fixed by #65
Closed

Add Polygon curve #52

RobPasMue opened this issue Sep 4, 2022 · 4 comments · Fixed by #65
Assignees
@Revathyvenugopal162
Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog

Comments

@RobPasMue
Copy link
Member

The Polygon class is one of the basic classes we need to be able to create. Basic constructor for DBU is exposed in #13.

Consider using their constructor and storing those properties as instance attributes.
@RobPasMue RobPasMue mentioned this issue Sep 4, 2022
Closed
27 tasks
@github-actions github-actions bot removed the PRIORITY label Sep 5, 2022
@RobPasMue RobPasMue added the PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog label Sep 5, 2022
@RobPasMue
Copy link
Member Author

FYI, consider using CircleShape as parent. Talk to @jorgepiloto or me if needed. You should be able to create the Polygon object from a circle that contains the Polygon. Stick to regular Polygons, of course. Irregular ones we will see how we handle them in the future (if needed).

@RobPasMue
Copy link
Member Author

Pinging @Revathyvenugopal162 for visibility

@chadqueen
Copy link
Contributor

SpaceClaim ctor: Polygon(Point3D origin, Direction dirX, Direction dirY, double innerRadius, int numSides)

@RobPasMue
Copy link
Member Author

Better thought... Let's stick to extending BaseShape for all shapes only. Don't extend the Circle. You may enter into complications perhaps. Stick to @chadqueen's ctor.

@Revathyvenugopal162 Revathyvenugopal162 mentioned this issue Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add polygon shape ansys/pyansys-geometry
3 participants
@chadqueen @RobPasMue @Revathyvenugopal162