Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polygon shape #65

Merged
merged 31 commits into from
Sep 8, 2022
Merged

Add polygon shape #65

merged 31 commits into from
Sep 8, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Sep 7, 2022 •
edited
Loading

Add polygon shape from base shape. Fix #52

@github-actions github-actions bot added the enhancement New features or code improvements label Sep 7, 2022
RobPasMue
RobPasMue requested changes Sep 7, 2022
View reviewed changes
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review September 7, 2022 15:04
akaszynski
akaszynski reviewed Sep 7, 2022
View reviewed changes
tests/test_shapes.py Outdated Show resolved Hide resolved
MaxJPRey
MaxJPRey approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jorgepiloto
jorgepiloto requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this, @Revathyvenugopal162. I just left a couple of comments before this can be merged 🚀

src/ansys/geometry/core/shapes/polygon.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Show resolved Hide resolved
RobPasMue
RobPasMue requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some code suggestions 😄. Almost there

src/ansys/geometry/core/shapes/__init__.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/sketch.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/polygon.py Outdated Show resolved Hide resolved
@Revathyvenugopal162 @RobPasMue
Apply suggestions from code review
717fad3 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@RobPasMue RobPasMue mentioned this pull request Sep 8, 2022
Closed
27 tasks
RobPasMue
RobPasMue approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jorgepiloto
jorgepiloto approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this, @Revathyvenugopal162 🚀

@RobPasMue
Copy link
Member

Let's merge it :)

@RobPasMue RobPasMue merged commit 8810045 into main Sep 8, 2022
@RobPasMue RobPasMue deleted the feat/add-polygon-shape branch September 8, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@chadqueen chadqueen Awaiting requested review from chadqueen

@akaszynski akaszynski Awaiting requested review from akaszynski

Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Polygon curve
6 participants
@Revathyvenugopal162 @RobPasMue @chadqueen @akaszynski @jorgepiloto @MaxJPRey