Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor classes to avoid code duplication: Units scope #68

Closed
RobPasMue opened this issue Sep 8, 2022 · 1 comment · Fixed by #71
Closed

Refactor classes to avoid code duplication: Units scope #68

RobPasMue opened this issue Sep 8, 2022 · 1 comment · Fixed by #71
Assignees
@RobPasMue

Comments

@RobPasMue
Copy link
Member

As @akaszynski mentioned, most of the capabilities related with units and its methods are the same everywhere but we are duplicating code. Let's consider extending from a common PhysicalQuantity class (or similar name) that handles units for our base objects.
@RobPasMue RobPasMue self-assigned this Sep 8, 2022
@RobPasMue RobPasMue mentioned this issue Sep 8, 2022
Merged
@RobPasMue
Copy link
Member Author

Starting with this one. Let's see what comes out of it.

@RobPasMue RobPasMue linked a pull request Sep 8, 2022 that will close this issue
Creating ansys.geometry.core.misc.units submodule #71
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobPasMue RobPasMue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Creating ansys.geometry.core.misc.units submodule ansys/pyansys-geometry
1 participant
@RobPasMue