Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing Line and Segment classes #54

Merged
merged 46 commits into from
Sep 8, 2022
Merged

Implementing Line and Segment classes #54

merged 46 commits into from
Sep 8, 2022

Conversation

RobPasMue
Copy link
Member

Resolves #33, #34 and #43

@RobPasMue RobPasMue self-assigned this Sep 5, 2022
This was linked to issues Sep 5, 2022
Increase robustness of Line #43
Closed
Add Line primitive geometry class #34
Closed
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 5, 2022
@RobPasMue RobPasMue mentioned this pull request Sep 7, 2022
Merged
chadqueen
chadqueen approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@chadqueen chadqueen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few concerns/comments/questions, but can revise over time if not able to work into the PR. This is a good first implementation.

src/ansys/geometry/core/shapes/base.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/circle.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/circle.py Show resolved Hide resolved
src/ansys/geometry/core/shapes/line.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/shapes/line.py Show resolved Hide resolved
RobPasMue and others added 2 commits September 7, 2022 16:26
@RobPasMue @MaxJPRey @chadqueen
Apply suggestions from code review
1ef6a63 
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
Co-authored-by: Chad Queen <chadqueen82@gmail.com>
@RobPasMue
Typo in modeling
45f91bf
MaxJPRey
MaxJPRey reviewed Sep 7, 2022
View reviewed changes
tests/test_misc_checks.py Outdated Show resolved Hide resolved
MaxJPRey
MaxJPRey reviewed Sep 7, 2022
View reviewed changes
tests/test_misc_checks.py Outdated Show resolved Hide resolved
akaszynski
akaszynski previously requested changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. Let's start subclassing as needed to reduce code duplication and rename LineShape to Line.

@RobPasMue RobPasMue enabled auto-merge (squash) September 8, 2022 06:05
@RobPasMue RobPasMue dismissed akaszynski’s stale review September 8, 2022 06:18

Remaining issue (code refactoring) will be handled in #63. Thanks for your comments @akaszynski!

@RobPasMue
Copy link
Member Author

Sorry, not #63 but #68!!!

@RobPasMue RobPasMue merged commit da5dffd into main Sep 8, 2022
@RobPasMue RobPasMue deleted the feat/improve-line-segment branch September 8, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadqueen chadqueen chadqueen approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@akaszynski akaszynski akaszynski left review comments

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

@Revathyvenugopal162 Revathyvenugopal162 Awaiting requested review from Revathyvenugopal162

Assignees

@RobPasMue RobPasMue

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase robustness of Line Add Line primitive geometry class Add Line Segment primitive geometry class
5 participants
@RobPasMue @chadqueen @akaszynski @MaxJPRey @Revathyvenugopal162