Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Box shape to ansys.geometry.core.shapes subpackage #99

Closed
chadqueen opened this issue Sep 19, 2022 · 3 comments · Fixed by #105
Closed

Add Box shape to ansys.geometry.core.shapes subpackage #99

chadqueen opened this issue Sep 19, 2022 · 3 comments · Fixed by #105
Assignees
Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog

Comments

@chadqueen
Copy link
Contributor

Maybe all of this is contained client side but would be nice to move server side in either this first implementation or future refactors.

Accept in the required inputs to create a box in a method on the Component class. The call to the server should return a Body that will be nested under the Component in context.

Example client script is within BoardCreationCommonHelper for reference.

@chadqueen chadqueen linked a pull request Sep 19, 2022 that will close this issue
@chadqueen
Copy link
Contributor Author

#105 simply adds convenience for sketching, would still also need an "Add 3D Box" method as well. Tagged sketch implementation as another route for the user while waiting on gRPC endpoing for adding the 3D Box

@RobPasMue
Copy link
Member

@chadqueen your "Add 3D box" already exists - see #21

@RobPasMue
Copy link
Member

FYI - building a box should be always client side. This shape/body ay be of use to any potential end-user without needing to build a server connection

@RobPasMue RobPasMue changed the title Implement CreateBox Add Box shape to ansys.geometry.core.shapes subpackage Sep 20, 2022
@RobPasMue RobPasMue added the PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog label Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants