Add slot and box shape primitives for sketching #105
Conversation
|
These two shapes are combinations of other shapes. Could use some thoughts about how to handle the conversion to gRPC messages. For instance, should BaseShape have a method to "GetPrimitives" where something like Circle returns self and something like Box returns 4 segments and Pill returns 2 segments and 2 arcs? Both of these are convenience methods for users as they could be constructed from the existing primitives. The value is that it groups the primitives within the new shapes for actions like translation and resizing. All feedback welcome, and if anyone would like to contribute/finish, feel free. |
|
Hmm I like this PR! :) Let me try and work on it throughout the day! :) |
|
Let's go with |
chadqueen
changed the title
github-actions
bot
added
the
documentation
|
BTW... for creating a box, we should also be able to provide a min/max point... not only width/height |
Totally. Once we are handling 2D better within the sketch we can do this. For now I mimicked the other shapes to provide a center and parameters. |
LocalPoints returned in meters by default.
|
Unlinking issue to avoid its closure. Thanks @chadqueen! I'll review it first thing Monday morning |
There was a problem hiding this comment.
LGTM! Apart from my comments. I'll work on those personally. Good job @chadqueen.
No description provided.