-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sweeping chains and profiles #1056
Conversation
Co-authored-by: Jonah Boling <56607167+jonahrb@users.noreply.github.com>
Seems like it requires a new API package : https://github.com/ansys/pyansys-geometry/actions/runs/8277110677/job/22646929425?pr=1056#step:12:150 |
@dastan-ansys @jonahrb - when creating a PR check the boxes properly and ensure you follow instructions. @dastan-ansys - you have not assigned yourself as the PR owner. I will add you this time but please follow conventions for next time =) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1056 +/- ##
==========================================
+ Coverage 89.96% 90.22% +0.26%
==========================================
Files 93 93
Lines 6805 6835 +30
==========================================
+ Hits 6122 6167 +45
+ Misses 683 668 -15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking merge until tests are available
- use trim() to create a TrimmedCurve/TrimmedSurface from Curve/Surface - refactor TrimmedSurface constructor
…ys/pyansys-geometry into feat/sweep-chain-and-profile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We are going to need examples in order for users to understand how to use these APIs. Please work on this ASAP - it can be done in a subsequent PR
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
for more information, see https://pre-commit.ci
Description
Implementing sweeping chain and sweeping profile in PyAnsys.
Checklist
feat: extrude circle to cylinder
)