Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sweeping chains and profiles #1056

Merged
merged 22 commits into from
Mar 18, 2024
Merged

Conversation

dastan-ansys
Copy link
Contributor

@dastan-ansys dastan-ansys commented Mar 13, 2024

Description

Implementing sweeping chain and sweeping profile in PyAnsys.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@dastan-ansys dastan-ansys requested a review from a team as a code owner March 13, 2024 19:07
@github-actions github-actions bot added the enhancement New features or code improvements label Mar 13, 2024
@dastan-ansys dastan-ansys changed the title added the client-side implementations of sweeping functions. feat/sweeping-chains-and-profiles Mar 13, 2024
@dastan-ansys dastan-ansys changed the title feat/sweeping-chains-and-profiles feat: sweeping-chains-and-profiles Mar 13, 2024
RobPasMue and others added 2 commits March 14, 2024 08:27
@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Mar 14, 2024

Wiz Scan Summary

IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 0🔑

@RobPasMue
Copy link
Member

@RobPasMue
Copy link
Member

@dastan-ansys @jonahrb - when creating a PR check the boxes properly and ensure you follow instructions. @dastan-ansys - you have not assigned yourself as the PR owner. I will add you this time but please follow conventions for next time =)

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.22%. Comparing base (f433eba) to head (72b3770).

Files Patch % Lines
src/ansys/geometry/core/shapes/surfaces/surface.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   89.96%   90.22%   +0.26%     
==========================================
  Files          93       93              
  Lines        6805     6835      +30     
==========================================
+ Hits         6122     6167      +45     
+ Misses        683      668      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking merge until tests are available

@jonahrb jonahrb requested a review from RobPasMue March 16, 2024 14:35
jonahrb
jonahrb previously approved these changes Mar 16, 2024
@RobPasMue RobPasMue changed the title feat: sweeping-chains-and-profiles feat: sweeping chains andprofiles Mar 18, 2024
@RobPasMue RobPasMue changed the title feat: sweeping chains andprofiles feat: sweeping chains and profiles Mar 18, 2024
RobPasMue
RobPasMue previously approved these changes Mar 18, 2024
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We are going to need examples in order for users to understand how to use these APIs. Please work on this ASAP - it can be done in a subsequent PR

src/ansys/geometry/core/shapes/surfaces/surface.py Outdated Show resolved Hide resolved
tests/integration/test_design.py Outdated Show resolved Hide resolved
tests/integration/test_design.py Outdated Show resolved Hide resolved
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
jonahrb and others added 3 commits March 18, 2024 10:08
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@RobPasMue RobPasMue enabled auto-merge (squash) March 18, 2024 14:26
@RobPasMue RobPasMue merged commit fc18018 into main Mar 18, 2024
35 checks passed
@RobPasMue RobPasMue deleted the feat/sweep-chain-and-profile branch March 18, 2024 14:26
@RobPasMue RobPasMue mentioned this pull request Mar 18, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants