Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding containers to automatic launcher #1090

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Conversation

RobPasMue
Copy link
Member

Description

Adding new version containers to the enum

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Apr 1, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner April 1, 2024 13:22
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 1, 2024
@RobPasMue RobPasMue requested a review from PipKat as a code owner April 1, 2024 13:24
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (f567f8f) to head (193aef6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1090   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files          93       93           
  Lines        6835     6839    +4     
=======================================
+ Hits         6167     6171    +4     
  Misses        668      668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit 682bd78 into main Apr 2, 2024
40 checks passed
@RobPasMue RobPasMue deleted the feat/adding-containers branch April 2, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants