Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: beartype upper limit on v0.18 #1095

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Apr 3, 2024

Description

Limiting to older versions of beartype (temporarily).

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Apr 3, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner April 3, 2024 05:59
@github-actions github-actions bot added the bug Something isn't working label Apr 3, 2024
@RobPasMue RobPasMue requested a review from PipKat as a code owner April 3, 2024 06:00
@RobPasMue
Copy link
Member Author

We need to limit the beartype version to <v0.18 - breaking changes are coming with it. I'll investigate in further PRs.

@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 3, 2024
@RobPasMue RobPasMue changed the title fix: beartype complaint build: beartype upper limit on v0.18 Apr 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (8eb320b) to head (455a894).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   90.23%   90.23%           
=======================================
  Files          93       93           
  Lines        6839     6839           
=======================================
  Hits         6171     6171           
  Misses        668      668           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit acbcf29 into main Apr 3, 2024
40 checks passed
@RobPasMue RobPasMue deleted the fix/beartype-complaint branch April 3, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants