Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add export_to functions #1147

Merged
merged 11 commits into from
Apr 19, 2024
Merged

feat: add export_to functions #1147

merged 11 commits into from
Apr 19, 2024

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Apr 19, 2024

Description

Adding export_to_* functions to simplify the process for end users.

Issue linked

Closes #1130

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Apr 19, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner April 19, 2024 10:58
@RobPasMue RobPasMue linked an issue Apr 19, 2024 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Apr 19, 2024
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments.

tests/integration/test_design_export.py Show resolved Hide resolved
src/ansys/geometry/core/designer/design.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.22222% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.75%. Comparing base (9757402) to head (fd77ffe).

Files Patch % Lines
src/ansys/geometry/core/designer/design.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   90.72%   90.75%   +0.02%     
==========================================
  Files          93       93              
  Lines        6933     6964      +31     
==========================================
+ Hits         6290     6320      +30     
- Misses        643      644       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue enabled auto-merge (squash) April 19, 2024 12:39
@RobPasMue RobPasMue merged commit fb35396 into main Apr 19, 2024
38 checks passed
@RobPasMue RobPasMue deleted the feat/add-export_to_methods branch April 19, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add export_to_* methods
4 participants