Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design organization example #181

Merged
merged 8 commits into from
Oct 20, 2022
Merged

Design organization example #181

merged 8 commits into from
Oct 20, 2022

Conversation

chadqueen
Copy link
Contributor

The example describes the design tree hierarchy and creates four bodies. The bodies are divided across the design component and two nested components. Multiple body creation methods were utilized. The final plot:

image

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 19, 2022
@chadqueen chadqueen linked an issue Oct 19, 2022 that may be closed by this pull request
Improve the Examples section of the documentation #141
Closed
4 tasks
@RobPasMue
Copy link
Member

@Revathyvenugopal162 is also working on this task as far as I know. Please coordinate yourselves to submit a common PR.

RobPasMue
RobPasMue reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a bad start. But I'd suggest making it more didactical. Explaining other design concepts etc.

We should work on:

  • Specific Body examples to show all the possible operations to do with the Body class
  • Same for Component
  • Same for Design

src/ansys/geometry/core/designer/component.py Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
@RobPasMue RobPasMue mentioned this pull request Oct 20, 2022
Merged
3 tasks
chadqueen and others added 2 commits October 20, 2022 09:19
@chadqueen @RobPasMue
Apply suggestions from code review
3ccfb19 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@chadqueen
Merge branch 'main' into docs/design-org-example
1585baa
@RobPasMue
Copy link
Member

Remember to include the thumbnail! =)

RobPasMue
RobPasMue approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions, LGTM @chadqueen!

doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
doc/source/examples/design_organization.mystnb Outdated Show resolved Hide resolved
@chadqueen @RobPasMue
Apply suggestions from code review
74e976a 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
Revathyvenugopal162
Revathyvenugopal162 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobPasMue RobPasMue enabled auto-merge (squash) October 20, 2022 14:16
@RobPasMue RobPasMue merged commit 2b3a262 into main Oct 20, 2022
@RobPasMue RobPasMue deleted the docs/design-org-example branch October 20, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

Assignees

@chadqueen chadqueen

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the Examples section of the documentation
3 participants
@chadqueen @RobPasMue @Revathyvenugopal162