Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add matrix primitives #40

Merged
merged 59 commits into from
Sep 6, 2022
Merged

Add matrix primitives #40

merged 59 commits into from
Sep 6, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Sep 1, 2022 •
edited
Loading

Add matrix primitives
Refactor primitives test to test_primitives ad test_math

@github-actions github-actions bot added the enhancement New features or code improvements label Sep 1, 2022
@RobPasMue RobPasMue self-requested a review September 1, 2022 15:25
RobPasMue
RobPasMue requested changes Sep 2, 2022
View reviewed changes
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
@chadqueen
Copy link
Contributor

Just wondering if we are recreating the wheel here, are there existing matrix libraries to rely upon?

RobPasMue
RobPasMue requested changes Sep 3, 2022
View reviewed changes
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
@RobPasMue RobPasMue mentioned this pull request Sep 3, 2022
Closed
27 tasks
RobPasMue
RobPasMue reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments, LGTM! We are almost there

src/ansys/geometry/core/primitives/__init__.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/primitives/matrix.py Outdated Show resolved Hide resolved
@Revathyvenugopal162 @MaxJPRey
Apply suggestions from code review
035cd36 
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
@Revathyvenugopal162 @RobPasMue
Apply suggestions from code review
d83fd63 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
MaxJPRey
MaxJPRey approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great @Revathyvenugopal162

RobPasMue
RobPasMue approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor corrections.

src/ansys/geometry/core/math/__init__.py Outdated Show resolved Hide resolved
src/ansys/geometry/core/math/matrix.py Outdated Show resolved Hide resolved
@RobPasMue RobPasMue enabled auto-merge (squash) September 6, 2022 18:36
RobPasMue
RobPasMue reviewed Sep 6, 2022
View reviewed changes
tests/test_math.py Outdated Show resolved Hide resolved
@RobPasMue RobPasMue merged commit 25cf19d into main Sep 6, 2022
@RobPasMue RobPasMue deleted the feat/add-matrix-primitives branch September 6, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaszynski akaszynski akaszynski left review comments

@RobPasMue RobPasMue RobPasMue approved these changes

@chadqueen chadqueen Awaiting requested review from chadqueen

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

@MaxJPRey MaxJPRey Awaiting requested review from MaxJPRey

Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels
enhancement New features or code improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement transformations module
5 participants
@Revathyvenugopal162 @chadqueen @RobPasMue @akaszynski @MaxJPRey