Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-enable open file on Linux #817

Merged
merged 4 commits into from
Apr 16, 2024
Merged

feat: re-enable open file on Linux #817

merged 4 commits into from
Apr 16, 2024

Conversation

RobPasMue
Copy link
Member

Closes #799

@RobPasMue RobPasMue self-assigned this Oct 20, 2023
@github-actions github-actions bot added the bug Something isn't working label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (227e5fc) 91.10% compared to head (323ac8b) 91.10%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   91.10%   91.10%           
=======================================
  Files          84       84           
  Lines        6081     6081           
=======================================
  Hits         5540     5540           
  Misses        541      541

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
Copy link
Member Author

Requires server-side resolution - @b-matteo

RobPasMue
RobPasMue commented Feb 16, 2024
View reviewed changes
Copy link
Member Author

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha... the tests are being skipped. This needs to be solved first.

@RobPasMue
Copy link
Member Author

This PR is dependent on #992

@RobPasMue RobPasMue marked this pull request as ready for review April 16, 2024 07:56
@RobPasMue RobPasMue requested a review from a team as a code owner April 16, 2024 07:56
b-matteo
b-matteo approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @RobPasMue

@RobPasMue RobPasMue enabled auto-merge (squash) April 16, 2024 08:07
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.72%. Comparing base (cc6c4e6) to head (bef045a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #817   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files          93       93           
  Lines        6931     6931           
=======================================
  Hits         6288     6288           
  Misses        643      643

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit f99c8fc into main Apr 16, 2024
36 checks passed
@RobPasMue RobPasMue deleted the fix/open-file-linux branch April 16, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-matteo b-matteo b-matteo approved these changes

Assignees

@RobPasMue RobPasMue

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open file broken on Linux service
4 participants
@RobPasMue @codecov-commenter @b-matteo @pyansys-ci-bot