Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24.1 changes #216

Merged
merged 13 commits into from
Jul 18, 2023
Merged

24.1 changes #216

merged 13 commits into from
Jul 18, 2023

Conversation

mkundu1
Copy link
Collaborator

@mkundu1 mkundu1 commented Jul 14, 2023

No description provided.

raph-luc
raph-luc approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to make it clearer that we are working with full "file paths" and not just "file names". Also a question regarding the container mount path usage.

tests/test_parametric_workflow.py Outdated Show resolved Hide resolved
tests/test_local_parametric_setup.py Outdated Show resolved Hide resolved
tests/test_local_parametric_run.py Outdated Show resolved Hide resolved
examples/00-parametric/parametric_static_mixer_1.py Show resolved Hide resolved
doc/source/conf.py Show resolved Hide resolved
@mkundu1 mkundu1 linked an issue Jul 18, 2023 that may be closed by this pull request
Parametric APIs duplicate_design_point/set_as_current not working with the latest Fluent #213
Closed
@mkundu1 mkundu1 merged commit 70e8f9b into main Jul 18, 2023
13 checks passed
@mkundu1 mkundu1 deleted the maint/241 branch July 18, 2023 00:50
@mkundu1 mkundu1 mentioned this pull request Jul 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raph-luc raph-luc raph-luc approved these changes

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@hpohekar hpohekar hpohekar approved these changes

@prmukherj prmukherj prmukherj approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parametric APIs duplicate_design_point/set_as_current not working with the latest Fluent
5 participants
@mkundu1 @seanpearsonuk @hpohekar @prmukherj @raph-luc