Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing initialize method, tests maintenance, adding settings api test #238

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

raph-luc
Copy link
Member

@raph-luc raph-luc commented Sep 20, 2023

Closes #114

First steps addressing #178

Changes:

  • Adding fluent_version marker for tests, e.g. pytest --fluent-version=24.1 (same as pyfluent repo)
  • Adding self_hosted marker for tests, to specify tests that would have issues running on GitHub runners due to resource limitations. pytest --self-hosted runs will only run the self_hosted tests. If --self-hosted is not specified, then the tests marked with self_hosted will not be executed
  • Set up CI to run self-hosted tests separately and in parallel to the non-self-hosted runs, speeding up CI
  • Changed tests to make use of the GitHub-hosted runners whenever possible, instead of the self-hosted runners, to speed up CI runs
  • Added an alternative version to the test_parametric_workflow test, called test_parametric_workflow_settings_api, that uses settings API and removes all direct tui calls
  • Added ParametricStudy.reset_study_registry() and ParametricStudyRegistry.clear_registry() methods to deal with issues that were occurring due to pre-existing studies in the current Python interpreter's _shared_parametric_study_registry from previous tests
  • Due to Fluent cannot compile code for session.project.save_as #121, where parametric project save_as calls fail on Windows and GitHub runners, test_parametric_workflow_settings_api was set to run on self-hosted Linux runners, temporarily working around this issue
  • Added debug logging (pyfluent-core) to the CI tests

@raph-luc raph-luc merged commit 449e95d into main Sep 21, 2023
17 checks passed
@raph-luc raph-luc deleted the maint/tests_and_initialize branch September 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParametricStudy.initialize
4 participants