Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update requirements #263

Merged
merged 16 commits into from
Mar 14, 2024
Merged

ci: Update requirements #263

merged 16 commits into from
Mar 14, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Mar 5, 2024

closes #264, #265, #266

  1. Updated requirements.
  2. Fixed download_file argument. (return_only_filename -> return_without_path)
  3. Fixed CaseReader argument (case_filepath -> case_file_name)

@hpohekar hpohekar linked an issue Mar 5, 2024 that may be closed by this pull request
@hpohekar hpohekar linked an issue Mar 5, 2024 that may be closed by this pull request
@mkundu1
Copy link
Collaborator

mkundu1 commented Mar 5, 2024

We need the latest aliasing fixes from PyFluent to fix some unittests. I will create a dev release and update the pyfluent version.

mkundu1 and others added 5 commits March 5, 2024 12:12
This reverts commit 60eea4f.
* build: Update CI to include 24.2

* build: Update CI to include 24.2

* Update makefile.

* Update tests.

* Revert.
@mkundu1
Copy link
Collaborator

mkundu1 commented Mar 8, 2024

The current 24.2 failure is due to a Fluent, I have a PR on Fluent side.

@mkundu1
Copy link
Collaborator

mkundu1 commented Mar 14, 2024

@hpohekar Feel free to merge this PR irrespective of the 24.2 failures. The 24.2 failures would be fixed with Fluent side change.

@hpohekar hpohekar merged commit 2de3b9a into main Mar 14, 2024
21 of 23 checks passed
@hpohekar hpohekar deleted the fix/update_requirements branch March 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CaseReader argument. Fix download_file argument Update requirements.
4 participants