Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datamodel attr caching #1533

Merged
merged 8 commits into from May 3, 2023
Merged

Datamodel attr caching #1533

merged 8 commits into from May 3, 2023

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Apr 4, 2023 •
edited

  1. Cache datamodel attribute values in client - some changes are pending to unsubscribe the on-attribute-changed listeners on deleting named objects.
  2. add_on_deleted method at datamodel objects.

@mkundu1 mkundu1 linked an issue Apr 4, 2023 that may be closed by this pull request
add attributes to the data model caching #1518
Closed
@mkundu1 mkundu1 changed the title Feat/attr cache Datamodel attr caching Apr 5, 2023
@mkundu1 mkundu1 changed the title Datamodel attr caching Datamodel attr caching - for review Apr 5, 2023
@mkundu1 mkundu1 marked this pull request as ready for review May 2, 2023 13:37
@mkundu1 mkundu1 changed the title Datamodel attr caching - for review Datamodel attr caching May 2, 2023
@seanpearsonuk
Copy link
Collaborator

@prmukherj we need one more reviewer for this PR. add_on_deleted will be useful for me.

@mkundu1 mkundu1 merged commit e0ed2ab into main May 3, 2023
17 checks passed
@mkundu1 mkundu1 deleted the feat/attr-cache branch May 3, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@prmukherj prmukherj prmukherj approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work ajain-work is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work dnwillia-work is a code owner

@hpohekar hpohekar Awaiting requested review from hpohekar hpohekar is a code owner

@alikasim72 alikasim72 Awaiting requested review from alikasim72

@h-krishnan h-krishnan Awaiting requested review from h-krishnan h-krishnan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add attributes to the data model caching
3 participants
@mkundu1 @seanpearsonuk @prmukherj