Improving Linux usage documentation #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raph-luc
requested review from
mkundu1,
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar and
h-krishnan
as code owners
mkundu1
approved these changes
May 17, 2023
hpohekar
approved these changes
May 18, 2023
prmukherj
approved these changes
May 18, 2023
seanpearsonuk
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the documentation in
README.rstof theAWP_ROOTenv variable required to run it on Linux, as the required env variable is not set automatically, with examples.Also took this opportunity to streamline and move the Windows env var documentation from the 'Launching fluent' heading to the 'Dependencies' heading, together with the Linux documentation.
edit: also removed the link to the FAQs "for more information about Fluent location", as I didn't find anything there that adds to the readme for this