Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker API support and container launch exposure #1748

Merged
merged 9 commits into from Jul 6, 2023
Merged

Conversation

raph-luc
Copy link
Member

@raph-luc raph-luc commented Jun 30, 2023

Documentation

image

image

configure_container_dict() documentation

image

image

To-do (future PRs):

  1. Add .env var file for all PyFluent environment variables, and add documentation of how it can be used
  2. Are there any scenarios where Docker API/SDK as exposed here does not provide enough functionality, that we should add support for docker compose (https://github.com/docker/compose) in PyFluent? Cloud-native?

Also, see comments below for other changes

@raph-luc raph-luc linked an issue Jun 30, 2023 that may be closed by this pull request
@dnwillia
Copy link
Collaborator

dnwillia commented Jul 1, 2023

See comments below

Raphael is there an issue that documents what this is for?

@raph-luc
Copy link
Member Author

raph-luc commented Jul 3, 2023

@dnwillia Raphael is there an issue that documents what this is for?

Hi Dan, yes, there is an issue associated to this draft PR, it should appear under the "Development" heading in the right sidebar: #1616 (see Sean's reply in particular)

setup.py Outdated Show resolved Hide resolved
@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Jul 5, 2023

We might want to refactor the launcher code again. The functions here have a tendency to grow. It would be good to keep the functions small so that whole is modular - we want to promote reuse for PyCFX etc. I will create a separate issue.

#1761

raph-luc and others added 3 commits July 5, 2023 12:07
pyproject.toml Show resolved Hide resolved
@raph-luc
Copy link
Member Author

raph-luc commented Jul 5, 2023

By the way, with these changes (mainly I believe due to time.sleep -> timeout_loop()), the time taken for all tests to complete appears to have been reduced by approximately 20%, e.g., unit test v232 from 25 min to 20 min, unit test v241 from 14 min to 11 min, disregarding other factors
(see https://github.com/ansys/pyfluent/actions/runs/5467911359/jobs/9955261111 vs https://github.com/ansys/pyfluent/actions/runs/5467665522/jobs/9954548633)

@raph-luc raph-luc enabled auto-merge (squash) July 6, 2023 13:12
@raph-luc raph-luc merged commit d1748fb into main Jul 6, 2023
21 checks passed
@raph-luc raph-luc deleted the feat/docker_api branch July 6, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants