Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meshing.meshing #1757

Merged
merged 5 commits into from Jul 6, 2023
Merged

Update meshing.meshing #1757

merged 5 commits into from Jul 6, 2023

Conversation

prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented Jul 4, 2023

The class src\ansys\fluent\core\meshing\meshing.py::Meshing provides some additional attributes over meshing datamodel root, which are already provided by meshing session. So this have been removed.

There were some client side testing to test the independent datamodel server (which did not have any dependencies on pyfluent repo), which have now been dumped in the https://github.com/ansys/pyfluent-datamodel-server/ repo for future reference.

@mkundu1
Copy link
Contributor

mkundu1 commented Jul 5, 2023

Another cleanup: private properties _meshing_root, _workflow_se can be removed.

@prmukherj prmukherj merged commit 4bbc454 into main Jul 6, 2023
21 checks passed
@prmukherj prmukherj deleted the maint/meshing_updates branch July 6, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

src\ansys\fluent\core\meshing\meshing.py::Meshing test_client.py
4 participants