Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove settings API arguments method #1760

Merged
merged 1 commit into from Jul 5, 2023
Merged

Remove settings API arguments method #1760

merged 1 commit into from Jul 5, 2023

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Jul 5, 2023 •
edited

Removed settings API arguments method.

image

@hpohekar hpohekar linked an issue Jul 5, 2023 that may be closed by this pull request
Remove settings API arguments method which only returns Scheme-level information #1756
Closed
seanpearsonuk
seanpearsonuk approved these changes Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this so quickly @hpohekar.

@hpohekar hpohekar merged commit b606cb3 into main Jul 5, 2023
21 checks passed
@hpohekar hpohekar deleted the fix/remove_arguments_method branch July 5, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

@ajain-work ajain-work Awaiting requested review from ajain-work ajain-work is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work dnwillia-work is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan h-krishnan is a code owner

@raph-luc raph-luc Awaiting requested review from raph-luc raph-luc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove settings API arguments method which only returns Scheme-level information
3 participants
@hpohekar @seanpearsonuk @prmukherj