Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decompress artifact for doc indexing #2136

Merged
merged 1 commit into from Oct 13, 2023
Merged

fix: decompress artifact for doc indexing #2136

merged 1 commit into from Oct 13, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Oct 13, 2023 •
edited

fix the issue with indexing

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review October 13, 2023 09:44
@Revathyvenugopal162
Copy link
Contributor Author

Fixes ansys/pymeilisearch#90 issue as https://github.com/ansys/pyfluent/actions/runs/6505176185/job/17672145034 starts scraping

jorgepiloto
jorgepiloto approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I should noticed this when implementing this step.

raph-luc
raph-luc approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@raph-luc raph-luc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the help @Revathyvenugopal162 !

@raph-luc raph-luc linked an issue Oct 13, 2023 that may be closed by this pull request
Documentation search feature isn't working #2093
Closed
@Revathyvenugopal162 Revathyvenugopal162 merged commit b2c6d71 into main Oct 13, 2023
22 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the test/search-engine branch October 13, 2023 13:04
mkundu1 pushed a commit that referenced this pull request Oct 13, 2023
@Revathyvenugopal162 @mkundu1
fix: decompress artifact for doc indexing (#2136)
f4c7aaa
@mkundu1 mkundu1 mentioned this pull request Oct 13, 2023
Merged
mkundu1 added a commit that referenced this pull request Oct 14, 2023
@mkundu1 @Revathyvenugopal162
fix: decompress artifact for doc indexing (#2136) (#2140)
a1b3e8d 
* fix: decompress artifact for doc indexing (#2136)

* Temporarily skipping rpvar tests till the docker image is updated

---------

Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
raph-luc added a commit that referenced this pull request Oct 26, 2023
@raph-luc
Revert "fix: decompress artifact for doc indexing (#2136)"
3586022 
This reverts commit b2c6d71.
raph-luc added a commit that referenced this pull request Oct 30, 2023
@raph-luc
Reverting documentation search function (#2178)
841154d 
* Revert "fix: decompress artifact for doc indexing (#2136)"

This reverts commit b2c6d71.

* Revert "fix: doc-artifact name when uploading doc index (#2040)"

This reverts commit d34c88f.

* Revert "doc: enhance search bar experience by using pymeilisearch (#2024)"

This reverts commit 447647f.
raph-luc added a commit that referenced this pull request Oct 31, 2023
@raph-luc
Reverting documentation search function (#2178)
3cb87ac 
* Revert "fix: decompress artifact for doc indexing (#2136)"

This reverts commit b2c6d71.

* Revert "fix: doc-artifact name when uploading doc index (#2040)"

This reverts commit d34c88f.

* Revert "doc: enhance search bar experience by using pymeilisearch (#2024)"

This reverts commit 447647f.
raph-luc added a commit that referenced this pull request Nov 1, 2023
@raph-luc
Reverting stable documentation search function (#2186)
b084726 
* Reverting documentation search function (#2178)

* Revert "fix: decompress artifact for doc indexing (#2136)"

This reverts commit b2c6d71.

* Revert "fix: doc-artifact name when uploading doc index (#2040)"

This reverts commit d34c88f.

* Revert "doc: enhance search bar experience by using pymeilisearch (#2024)"

This reverts commit 447647f.

* empty commit to force tests to run

* testing fix to codeql yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@hpohekar hpohekar hpohekar approved these changes

@raph-luc raph-luc raph-luc approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

@ajain-work ajain-work Awaiting requested review from ajain-work ajain-work is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work dnwillia-work is a code owner

@prmukherj prmukherj Awaiting requested review from prmukherj prmukherj is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan h-krishnan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation search feature isn't working
5 participants
@Revathyvenugopal162 @jorgepiloto @mkundu1 @hpohekar @raph-luc