feat: datamodel_tui refactoring #2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkundu1
commented
Jan 12, 2024
•
mkundu1
commented
- datamodel_tui refactoring for pyconsole work (extract a pure python service class to overwrite from pyconsole)
- A small change so that flobject.get_root can be overwritten in pyconsole (to avoid the hash comparison for pyconsole as that will always fail as it compares the local static-info and static-info over grpc)
- Refactoring required for monitor service implementation in PyConsole.
mkundu1
requested review from
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar,
h-krishnan and
raph-luc
as code owners
raph-luc
approved these changes
Jan 15, 2024
seanpearsonuk
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.