-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Reorganize codegen and generated API files #2767
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
hpohekar,
h-krishnan and
raph-luc
as code owners
May 1, 2024 14:31
mkundu1
changed the title
Re-organize codegen and generated API files
feat: Re-organize codegen and generated API files
May 1, 2024
mkundu1
changed the title
feat: Re-organize codegen and generated API files
feat: Reorganize codegen and generated API files
May 1, 2024
seanpearsonuk
approved these changes
May 1, 2024
raph-luc
approved these changes
May 1, 2024
PipKat
reviewed
May 1, 2024
PipKat
reviewed
May 1, 2024
PipKat
reviewed
May 1, 2024
PipKat
reviewed
May 1, 2024
PipKat
reviewed
May 1, 2024
hpohekar
approved these changes
May 2, 2024
prmukherj
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the high level changes of the source and packaging structure. The goal is to package the codegen module and use it in Fluent to generate the API files at some Fluent packaging path. There will be additional PRs to refactor the codegen code to use Fluent's local static info. We shall also create a zipped module for settings API files to include in Fluent package (not for PyFluent ATM as the expanded directory is useful as the .pyi files are read by intellisense).