Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show_gui and ui_mode value swap #2774

Merged
merged 2 commits into from
May 2, 2024
Merged

fix: show_gui and ui_mode value swap #2774

merged 2 commits into from
May 2, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented May 2, 2024

closes #2773 #2754

show_gui and ui_mode values were swapping. It's resolved now.

image

@hpohekar hpohekar changed the title fix: and value swap fix: show_gui and ui_mode value swap May 2, 2024
@hpohekar hpohekar linked an issue May 2, 2024 that may be closed by this pull request
pyfluent.launch_fluent(ui_mode=pyfluent.UIMode.GUI) or pyfluent.launch_fluent(ui_mode="gui") doesn't work anymore #2754
Closed
@seanpearsonuk
Copy link
Collaborator

@hpohekar @mkundu1
I have verified that all the following use cases are working properly with these changes:

>>> import ansys.fluent.core as pf
>>> s=pf.launch_fluent(show_gui=True)
>>> s2=pf.launch_fluent(ui_mode=pf.UIMode.GUI)
>>> s3=pf.launch_fluent(ui_mode=pf.UIMode.HIDDEN_GUI)

@hpohekar hpohekar merged commit 336769c into main May 2, 2024
26 checks passed
@hpohekar hpohekar deleted the fix/show_gui_value_swap_fix branch May 2, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 Awaiting requested review from mkundu1 mkundu1 is a code owner

@ajain-work ajain-work Awaiting requested review from ajain-work ajain-work is a code owner

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work dnwillia-work is a code owner

@h-krishnan h-krishnan Awaiting requested review from h-krishnan h-krishnan is a code owner

@raph-luc raph-luc Awaiting requested review from raph-luc raph-luc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hpohekar @seanpearsonuk @prmukherj