fix: settings allowed values check #2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohekar
requested review from
mkundu1,
seanpearsonuk,
ajain-work,
dnwillia-work,
prmukherj,
h-krishnan and
raph-luc
as code owners
h-krishnan
reviewed
May 3, 2024
h-krishnan
approved these changes
May 3, 2024
seanpearsonuk
approved these changes
May 3, 2024
|
@hpohekar please add a test. If you get stuck, please check with @h-krishnan. Please ensure your test fails with the original code. The test is important as we would be patching the product with this. |
seanpearsonuk
approved these changes
May 3, 2024
prmukherj
approved these changes
May 3, 2024
mkundu1
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2778